MAINT: restore access to deprecated private namespaces #15008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
requested review from
andyfaff,
ev-br,
ilayn,
larsoner,
perimosocordiae,
person142,
peterbell10 and
tylerjereddy
as code owners
These all had compatibility shims for direct import (e.g.
`from scipy.io import arff`), but not for access like:
from scipy import io
io.arff.xxx
This restores that access. The changes in this commit don't trigger
a deprecation warning, however use of any object in the now-restored
namespaces will trigger such a warning.
rgommers
force-pushed
the
depr-namespaces
branch
from
7b3d947
to
538dec5
Compare
perimosocordiae
approved these changes
Nov 10, 2021
|
Thanks for the review @perimosocordiae. Because this unbreaks some users of nightly builds and the changes to other submodules are all the same as those for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These all had compatibility shims for direct import (e.g.
from scipy.io import arff), but not for access like:This restores that access. The changes in this commit don't trigger
a deprecation warning, however use of any object in the now-restored
namespaces will trigger such a warning.
FYI @Smit-create, @czgdp1807