Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: bump test tolerance in test_linprog #15570

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Feb 10, 2022

Bump test tolerance in one of linprog tests. Otherwise it fails with

$ python dev.py -t scipy/optimize/tests/test_linprog.py::TestLinprogIPSpecific::test_solver_select
ninja: Entering directory `build'
[2/2] Generating scipy/generate-config with a custom command
Build OK
Installing, see meson-install.log...
Installation OK
Running tests for scipy version:1.9.0.dev0+1463.e98bdfd, installed at:/home/br/repos/scipy/scipy/build-install/lib/python3.8/site-packages/scipy
================================= test session starts ==================================
platform linux -- Python 3.8.10, pytest-7.0.0, pluggy-1.0.0
rootdir: /home/br/repos/scipy/scipy, configfile: pytest.ini
collected 1 item                                                                       

scipy/optimize/tests/test_linprog.py F                                           [100%]

======================================= FAILURES =======================================
_______________________ TestLinprogIPSpecific.test_solver_select _______________________
scipy/optimize/tests/test_linprog.py:2036: in test_solver_select
    assert_allclose(res1.fun, res2.fun,
E   AssertionError: 
E   Not equal to tolerance rtol=1e-15, atol=1e-15
E   linprog default solver unexpected result
E   Mismatched elements: 1 / 1 (100%)
E   Max absolute difference: 7.10542736e-14
E   Max relative difference: 1.1093651e-15
E    x: array(-64.049494)
E    y: array(-64.049494)

As a factoid, the failure is observed on ubuntu focal with stock OpenBLAS and is not observed with netlib atlas (both sudo apt-installed).

@ev-br ev-br added scipy.optimize maintenance Items related to regular maintenance tasks labels Feb 10, 2022
@mdhaber mdhaber merged commit b806a31 into scipy:main Feb 10, 2022
@ev-br ev-br added this to the 1.9.0 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.optimize
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants