MAINT: Clean up type: ignore comments related to third-party packages
#15625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cPickle` was removed back in python 3.0
…i`, rather than inline
BvB93
requested review from
tylerjereddy,
peterbell10,
ev-br and
rgommers
as code owners
BvB93
added
maintenance
| import cPickle as pickle | ||
| except ImportError: | ||
| import pickle | ||
| import pickle |
There was a problem hiding this comment.
ah, leftovers from Python 2.7!
…heir annotations Partially reverts scipy@304db39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a number of
# type: ignore[import]comments are scattered throughout the codebase due to third-party packages that lack type annotations. As they provide a reasonable amount of visual clutter, this PR attempts to remove them and deal with the fallout using one of two approaches:types-psutil).ignore_missing_importsoption for the package in mypy.ini.