Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Adds doit.db.db to gitignore #15999

Merged
merged 2 commits into from Apr 18, 2022

Conversation

thomasjpfan
Copy link
Contributor

Reference issue

Follow up to #15959

What does this implement/fix?

I noticed that doit creates this db file and I think it should be ignored by git.

@@ -85,6 +85,7 @@ installdir/
######
.doit.db.dat
.doit.db.dir
.doit.db.db
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, on my machine I see .doit.db that is not being ignored--you're getting the repeated extension on your end? I guess we can add yours and mine.

I noticed that the one I see is also in the pydoit .gitginore proper: https://github.com/pydoit/doit/blob/master/.gitignore#L2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I get .doit.db.db although it looks like the doit docs only mention .doit.db.

I updated the PR by adding .doit.db as well: fa56596 (#15999)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doit internally uses stdlib dbm [1]. Which implementation (and extension applied) depends on the default implementation in your installation. Unfortunately the extension added (or not) to the files is inconsistent...

[1] https://docs.python.org/3/library/dbm.html

@tylerjereddy tylerjereddy added the maintenance Items related to regular maintenance tasks label Apr 18, 2022
@tylerjereddy tylerjereddy added this to the 1.9.0 milestone Apr 18, 2022
@tylerjereddy tylerjereddy merged commit 5d3cf28 into scipy:main Apr 18, 2022
@tylerjereddy
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants