Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Adds doit.db.db to gitignore #15999

Merged
merged 2 commits into from Apr 18, 2022
Merged

MAINT: Adds doit.db.db to gitignore #15999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
002ea4c
MAINT: Adds doit.db.db to gitignore
thomasjpfan Apr 17, 2022
fa56596
MAINT: Adds doit.db to gitignore
thomasjpfan Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Expand Up @@ -85,6 +85,8 @@ installdir/
######
.doit.db.dat
.doit.db.dir
.doit.db.db
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, on my machine I see .doit.db that is not being ignored--you're getting the repeated extension on your end? I guess we can add yours and mine.

I noticed that the one I see is also in the pydoit .gitginore proper: https://github.com/pydoit/doit/blob/master/.gitignore#L2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I get .doit.db.db although it looks like the doit docs only mention .doit.db.

I updated the PR by adding .doit.db as well: fa56596 (#15999)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doit internally uses stdlib dbm [1]. Which implementation (and extension applied) depends on the default implementation in your installation. Unfortunately the extension added (or not) to the files is inconsistent...

[1] https://docs.python.org/3/library/dbm.html

.doit.db

# Paver generated files #
#########################
Expand Down