MAINT: Replace find_common_types #16398
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The
np.find_common_type
method is deprecated within numpy. See numpy/numpy#21703 and numpy/numpy#21742.This PR was triggered because
np.find_common_type
is one of performance bottlenecks inside thescipy.stats.rv_continuous
.This PR replaces the
np.find_common_type
withnp.results_type
ornp.promote_type
. These alternatives are both faster and maintained.Additional information
Microbenchmark results