Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: eps param no effect fixed #16630

Merged
merged 4 commits into from
Jul 20, 2022
Merged

BUG: eps param no effect fixed #16630

merged 4 commits into from
Jul 20, 2022

Conversation

njj67229
Copy link
Contributor

Reference issue

Closes #16600

What does this implement/fix?

Adds eps to be considered in kdtree's query_pairs() function

Additional information

Would you like me to implement a test in scipy/spatial/tests/test_kdtree.py that uses code similar to the example in issue #16600?

@tupui tupui added sprint Mentored-Sprint. Please do not work on this unless you're participating to a sprint scipy.spatial labels Jul 17, 2022
tupui
tupui reviewed Jul 17, 2022
View reviewed changes
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @njj67229. A test demonstrating that the parameter is being used would indeed be interesting to have.

@tupui tupui added the defect A clear bug or issue that prevents SciPy from being installed or used as expected label Jul 17, 2022
tupui
tupui approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I can verify the numbers, thanks @njj67229

@tupui tupui merged commit cfb0910 into scipy:main Jul 20, 2022
@tupui tupui added this to the 1.10.0 milestone Jul 20, 2022
@tylerjereddy tylerjereddy added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 16, 2022
@tylerjereddy
Copy link
Contributor

Seem to cherry-pick cleanly to the maintenance branch so I'll add a tentative backport label given this was considered a bug.

@tylerjereddy tylerjereddy modified the milestones: 1.10.0, 1.9.3 Oct 16, 2022
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Oct 16, 2022
@njj67229 @tupui @tylerjereddy
BUG: eps param no effect fixed (scipy#16630)
05c4908 
Co-authored-by: Pamphile Roy <roy.pamphile@gmail.com>
@tylerjereddy tylerjereddy mentioned this pull request Oct 16, 2022
Merged
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupui tupui tupui approved these changes

@EngNashar EngNashar EngNashar approved these changes

Assignees
No one assigned
Labels
defect A clear bug or issue that prevents SciPy from being installed or used as expected scipy.spatial sprint Mentored-Sprint. Please do not work on this unless you're participating to a sprint
Projects
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.

BUG: KDTree's optional argument eps seems to have no effect
4 participants
@njj67229 @tylerjereddy @tupui @EngNashar