Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpn nonscalar followup #16829

Merged
merged 2 commits into from
Aug 13, 2022
Merged

Interpn nonscalar followup #16829

merged 2 commits into from
Aug 13, 2022

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Aug 11, 2022

A simple follow-up to gh-16508:

  • trivially simplify a test
  • use somewhat smaller array sizes in test so that the new/updated tests are not seen in $ pythod dev.py test -s interpolate -- --durations.

The latter is dominated by RBFInterpolator tests, but that is definitely for some other day.

@ev-br
MAINT: interpolate: remove an unused variable
039b0cf
@ev-br
TST: interpolate: speed up test_nonscalar_values
920706b 
It used to test 7*11 values in a for loop, make it down to 7*3.
When parametrized across all methods, this was getting a little
too long.
@ev-br ev-br added scipy.interpolate maintenance Items related to regular maintenance tasks labels Aug 11, 2022
@ev-br ev-br requested a review from j-bowhay August 11, 2022 19:04
@ev-br
Copy link
Member Author

ev-br commented Aug 11, 2022

@j-bowhay would you be able to take a look?

@ev-br ev-br mentioned this pull request Aug 11, 2022
Merged
j-bowhay
j-bowhay approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tidying this up @ev-br! Changes are straight forward, LGTM

scipy/interpolate/tests/test_rgi.py
@@ -519,8 +519,7 @@ def test_nonscalar_values_2(self, method):

rng = np.random.default_rng(1234)

num_trailing_dims = 2
trailing_points = [3 + i for i in range(num_trailing_dims)]
trailing_points = (3, 2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree this is better now we are not parameterising

@ev-br
Copy link
Member Author

ev-br commented Aug 13, 2022

The CI comes back green, the PR is approved by Jake who looked at this code quite a bit over the last month or so, and itself it is a nearly trivial follow-up to gh-16508 --- it could have easily went in a part of it. Merging. Thanks @j-bowhay

@ev-br ev-br merged commit 7b239b7 into scipy:main Aug 13, 2022
@ev-br ev-br added this to the 1.10.0 milestone Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-bowhay j-bowhay j-bowhay approved these changes

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.interpolate
Projects
scipy.interpolate
Status: Done
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ev-br @j-bowhay