Fix compilation with -Wincompatible-function-pointer-types #16924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
added a commit
to pyodide/pyodide
that referenced
this pull request
Aug 30, 2022
GSW patch: TEOS-10/GSW-Python#99 galpy patch: jobovy/galpy#499 pyerfa patch: liberfa/pyerfa#89 astropy patch: astropy/astropy#13586 scipy patch: scipy/scipy#16924
tylerjereddy
added
maintenance
tylerjereddy
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
LGTM, it is a better match to the vendored function prototype we have from Qhull for qh_eachvoronoi_all as well.
The one CI failure is because the base branch you're using for this pull request is a bit old--it is missing the new pooch dependency needed for the doc build to succeed without warnings: git grep -E -i "pooch" | grep -E "circleci". So, that's not related.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest LLVM has gotten more strict when compiling with
-Wincompatible-function-pointer-types. It gets unhappy thatvoid*andFILE*are mixed up in this file.