Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: interpolate: discuss failure modes of SmoothBivariateSpline #17178

Merged
merged 1 commit into from Nov 4, 2022

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Oct 9, 2022

Reference issue

closes gh-2167, supersedes and closes gh-16918

What does this implement/fix?

Add recommendations for linear interpolation with SmoothBivariateSpline, link to a broader discussion. For discussion leading to this PR see #2167 (comment) , for technical details see gh-16918.

Additional information

For the moment, this links to a Jupyter notebook in a github gist outside of the scipy org. This is probably suboptimal.
Melissa @melissawm , would you please be able to give me a hand converting the notebook to the bright and shiny nbdev-based infra?

@ev-br ev-br added scipy.interpolate Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org labels Oct 9, 2022
@ev-br ev-br added this to In progress in scipy.interpolate Oct 9, 2022
@ev-br ev-br moved this from In progress to In review in scipy.interpolate Oct 11, 2022
Copy link
Member

@j-bowhay j-bowhay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-br
Copy link
Member Author

ev-br commented Nov 4, 2022

This has been reviewed by Atsushi Sakai and Jake Bowhay a while ago, and there are no further comments. An eventual location of the linked gist can be figured in a follow-up, which depends on gh-17322 and that is a big infrastructure change and needs more time to fully form.
Am hitting the green button, and will keep an eye on the myst-nb infrastructure development.
Thank @AtsushiSakai , @j-bowhay for reviews!

@ev-br ev-br merged commit b42d4eb into scipy:main Nov 4, 2022
scipy.interpolate automation moved this from In review to Done Nov 4, 2022
@ev-br ev-br added this to the 1.10.0 milestone Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org scipy.interpolate
Projects
Development

Successfully merging this pull request may close these issues.

BivariateSpline errors with kx=ky=1 (Trac #1642)
3 participants