Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: use conda for linters #17899

Merged
merged 1 commit into from
Jan 31, 2023
Merged

MAINT: use conda for linters #17899

merged 1 commit into from
Jan 31, 2023

Conversation

tupui
Copy link
Member

@tupui tupui commented Jan 31, 2023

Small PR to not use pip to install linters. Seems like both Ruff and cython-lint are now available on conda-forge.

[skip actions] [skip circle] [skip cirrus]
@tupui tupui added the maintenance Items related to regular maintenance tasks label Jan 31, 2023
@tupui tupui added this to the 1.11.0 milestone Jan 31, 2023
@tupui tupui requested a review from rgommers as a code owner January 31, 2023 16:59
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and resolves fine, so in it goes. Thanks @tupui

@rgommers rgommers merged commit d706622 into scipy:main Jan 31, 2023
@tupui tupui deleted the linters_conda branch February 2, 2023 17:53
@tupui
Copy link
Member Author

tupui commented Feb 2, 2023

CI failure on main is related to this.

Maybe there is a caching issue with the conda index. Locally it resolves, but I have a M1 so not totally equivalent, but still.

conda-forge/osx-64                                          Using cache
conda-forge/noarch                                          Using cache

Looking for: ['python', "setuptools[version='<60.0']", 'cython', 'compilers', "meson[version='>=0.64.0']", 'meson-python', 'ninja', 'numpy', 'openblas', 'pkg-config', 'libblas=[build=*openblas]', 'pybind11', 'pooch', "pythran[version='>=0.11.0']", 'pytest', 'pytest-cov', 'pytest-xdist', 'pytest-timeout', "asv[version='<0.5']", 'mypy', 'typing_extensions', 'sphinx', 'numpydoc', 'ipython', 'matplotlib', 'pydata-sphinx-theme==0.9.0', 'sphinx-design', 'mpmath', 'gmpy2', 'threadpoolctl', 'rich-click', 'click', "doit[version='>=0.36.0']", 'pydevtool', 'ruff', 'cython-lint']

Could not solve for environment specs
Encountered problems while solving:
  - nothing provides requested ruff
  - nothing provides requested cython-lint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants