-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix for side bar rendering on top of text issue #18189
Conversation
Update optimize.rst to fix overlapping issue
Thank you @harshvardhan2707, we will have a look shortly. @j-bowhay that could be a good start 😃 (we could use this PR to go over things.) Just FYI @harshvardhan2707, we are on-boarding Jake as a new maintainer, nothing to be concerned on your side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harshvardhan2707, this is pretty close just two changes are required:
- You have changed the wrong matrix, the change should be on line 291 instead
- The indented needs fixing eg.
\mathbf{H}
andbegin{bmatrix}
and subsequent lines should be on the same level of indentation. This will fix the rendering.
Two further things to keep in mind for the future:
- If possible try to skip CI that is not required (see https://docs.scipy.org/doc/scipy/dev/contributor/continuous_integration.html#skipping). In this case, as this is a doc-only change we don't need to run the whole test suite so you can add
[skip azp] [skip actions] [skip cirrus]
to the end of the commit message - You have made your changes in your main branch. This is fine for this PR but it will cause you unnecessary headaches in the future if you wish to continue contributing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @harshvardhan2707 LGTM, refguide failure is unrelated. Keep them coming!
* main: (52 commits) ENH: stats.vonmises.fit: treat case in which location likelihood equation has no solution(scipy#18190) MAINT: stats.kendalltau: avoid overflow (scipy#18193) DOC: Optimize: Fix for side bar rendering on top of Hessian (scipy#18189) MAINT: optimize.linprog: fix bound checks for integrality > 1 (scipy#18160) MAINT: Windows distutils cdist/pdist shims (scipy#18169) BUG: interpolate: add x-y length validation for `make_smoothing_spline`. (scipy#18188) ENH: Added `_sf` method for anglit distribution (scipy#17832) (scipy#18178) DOC: Fixed missing curly bracket in scipy.css DOC: Improving wording and docs for legacy directive DOC: Move legacy directive to not be first in the file DOC: Legacy directive custom styling DOC: Add optional argument to Legacy directive DOC: Ignore legacy directive in refguide_check DOC: Documenting the usage of the legacy directive DOC: Add legacy directive for documentation MAINT: stats.ecdf: store number at risk just before events (scipy#18187) DOC: cite pip issue about multiple `--config-settings` (scipy#18174) DOC: update links for ARPACK to point to ARPACK-NG (scipy#18173) MAINT: stats.logistic.fit: simplify MAINT: optimize.root_scalar: return gracefully when callable returns NaN (scipy#18172) ...
Reference issue
closes #17532
What does this implement/fix?
Fixes the overlapping text and sidebar issue
Additional information
Screenshot of issue
[skip azp] [skip actions] [skip cirrus]