Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: fix missing build dependency on cython signature .txt files #18257

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented Apr 7, 2023

Noticed this when looking at gh-18247.

@rgommers rgommers added Build issues Issues with building from source, including different choices of architecture, compilers and OS Meson Items related to the introduction of Meson as the new build system for SciPy labels Apr 7, 2023
@rgommers rgommers added this to the 1.11.0 milestone Apr 7, 2023
Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question: Are these files used for something else as well? If not, would it be a good idea (or even possible) to remove them from the source tree, regenerate them as part of the build process and add _cython_signature_generator.py as a dependency instead?

@rgommers
Copy link
Member Author

rgommers commented Apr 7, 2023

Are these files used for something else as well? If not, would it be a good idea (or even possible) to remove them from the source tree, regenerate them as part of the build process and add _cython_signature_generator.py as a dependency instead?

They're only used during the build process, for the linalg.cython_blas/cython_lapack modules as well as in scipy/_build_utils/_fortran.py for the ILP64 build.

I'd not want to remove them, because to regenerate them requires BLAS/LAPACK sources that aren't available at build time. And vendoring those would be a lot more code than simply committing these two .txt files.

@lysnikolaou
Copy link
Contributor

lysnikolaou commented Apr 7, 2023

Oh yes, that's right. Thanks!

Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well and CI is green

@tylerjereddy tylerjereddy merged commit 0d80293 into scipy:main Apr 7, 2023
@rgommers rgommers deleted the fix-cython-signatures-depends branch April 7, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build issues Issues with building from source, including different choices of architecture, compilers and OS Meson Items related to the introduction of Meson as the new build system for SciPy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants