-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: remove setup.py
based jobs from GitHub Actions and run less on merge to main
#18294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ralf. +1 to not run checks on merge. I just have 2 questions.
The new job is green. But not sure about the symbol hiding part. Can you confirm?
|
Well that's not helpful, on Windows:
Guess I should have read the docs, which say it's POSIX-only. Not sure if there's a better way to determine whether we're running a debug build of the interpreter - will look at that. |
Good catch, thanks. I'll need to fix that up. |
Note that there's one test which crashes with no traceback in pytest-xdist run: ``` [gw0] linux -- Python 3.10.6 /usr/bin/python3-dbg worker 'gw0' crashed while running 'signal/tests/test_signaltools.py::test_lfilter_bad_object' ``` So skip that on Python debug interpreters. [skip cirrus] [skip azp] [skip circle]
6c9a3fb
to
6301ae9
Compare
All green and tests seems ok now. Lets get this in. Thanks Ralf. |
Very satisfying I must say, this PR 😄 |
Totally, almost nothing is running now 😃 |
This also improves the
python-dbg
build, as well as makes visible that that job tests ATLAS as the BLAS/LAPACK library (that worked pleasantly well).There was one failing test,
test_signaltools.py::test_lfilter_bad_object
. That's super niche and we've had problems with it before, so I just skipped it when running in a debug interpreter.Running CI on merges of PRs to
main
is a waste of resources, and I find myself writing[skip ci]
in merge commits a lot. I disabled those to save resources. We did that for NumPy too recently, and that has worked fine.