Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: remove setup.py based jobs from GitHub Actions and run less on merge to main #18294

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

rgommers
Copy link
Member

This also improves the python-dbg build, as well as makes visible that that job tests ATLAS as the BLAS/LAPACK library (that worked pleasantly well).

There was one failing test, test_signaltools.py::test_lfilter_bad_object. That's super niche and we've had problems with it before, so I just skipped it when running in a debug interpreter.

Running CI on merges of PRs to main is a waste of resources, and I find myself writing [skip ci] in merge commits a lot. I disabled those to save resources. We did that for NumPy too recently, and that has worked fine.

@rgommers rgommers added the CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure label Apr 13, 2023
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ralf. +1 to not run checks on merge. I just have 2 questions.

.github/workflows/linux_meson.yml Show resolved Hide resolved
.github/workflows/linux_meson.yml Show resolved Hide resolved
@tupui
Copy link
Member

tupui commented Apr 13, 2023

The new job is green. But not sure about the symbol hiding part. Can you confirm?

  ./tools/check_pyext_symbol_hiding.sh build
  shell: /usr/bin/bash -e {0}
  env:
    CCACHE_DIR: /home/runner/work/scipy/scipy/.ccache
    INSTALLDIR: build-install
find: ‘build’: No such file or directory

@rgommers
Copy link
Member Author

Well that's not helpful, on Windows:

 E   AttributeError: module 'sys' has no attribute 'abiflags'

Guess I should have read the docs, which say it's POSIX-only. Not sure if there's a better way to determine whether we're running a debug build of the interpreter - will look at that.

@rgommers
Copy link
Member Author

The new job is green. But not sure about the symbol hiding part. Can you confirm?

Good catch, thanks. I'll need to fix that up.

Note that there's one test which crashes with no traceback in
pytest-xdist run:
```
[gw0] linux -- Python 3.10.6 /usr/bin/python3-dbg
worker 'gw0' crashed while running 'signal/tests/test_signaltools.py::test_lfilter_bad_object'
```
So skip that on Python debug interpreters.

[skip cirrus] [skip azp] [skip circle]
@tupui
Copy link
Member

tupui commented Apr 14, 2023

All green and tests seems ok now. Lets get this in. Thanks Ralf.

@tupui tupui merged commit 4c497c8 into scipy:main Apr 14, 2023
@rgommers rgommers deleted the ci-faster-actions branch April 14, 2023 11:07
@rgommers
Copy link
Member Author

Very satisfying I must say, this PR 😄

@tupui
Copy link
Member

tupui commented Apr 14, 2023

Totally, almost nothing is running now 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants