MAINT: interpolate: delete duplicated FITPACK bisplev interface #18617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C/C++
AtsushiSakai
added
maintenance
ev-br
approved these changes
Jun 2, 2023
* improve an error message based on code review [skip ci] Co-authored-by: Evgeni Burovski <evgeny.burovskiy@gmail.com>
tylerjereddy
reviewed
Jun 2, 2023
There was a problem hiding this comment.
It has a core developer approval, deletes a bunch of extraneous code, CI is passing, and diff also seems sensible to me as non-expert at least.
I merged Evgeni's small inline suggestion--note that the linter may complain about an f-string where it isn't needed though, not sure. That's easy to fix if it does though..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fix a part of #16729
What does this implement/fix?
This PR deletes duplicated FITPACK bisplev interface in _fitpackmodule.c.
Additional information