Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: fix 'no such option' error in build_scipy CI #18657

Merged
merged 1 commit into from Jun 11, 2023
Merged

MAINT: fix 'no such option' error in build_scipy CI #18657

merged 1 commit into from Jun 11, 2023

Conversation

alugowski
Copy link
Contributor

Pip's --install-option switch is deprecated.
Cython docs say the purpose of --no-cython-compile is for platforms that do not have wheels on PyPI, but they do have wheels for common Linux platforms that should cover this CI job.

See https://cython.readthedocs.io/en/latest/src/quickstart/install.html

Fixes gh-18654

@alugowski
MAINT: fix 'no such option' error in build_scipy CI
d60b66b 
Pip's `--install-option` switch is deprecated.
Cython docs say the purpose of `--no-cython-compile` is for platforms
that do not have wheels on PyPI, but they do have wheels for common
Linux platforms that should cover this CI job.

See https://cython.readthedocs.io/en/latest/src/quickstart/install.html

Fixes scipy#18654
@alugowski alugowski requested a review from larsoner as a code owner June 11, 2023 01:32
@alugowski
Copy link
Contributor Author

Indeed cython is being installed from a pre-compiled wheel:

Collecting cython
  Downloading Cython-0.29.35-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.manylinux_2_24_x86_64.whl (2.0 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 2.0/2.0 MB 34.8 MB/s eta 0:00:00

Installing collected packages: cython
Successfully installed cython-0.29.35

https://app.circleci.com/pipelines/github/scipy/scipy/20624/workflows/ffb81533-36de-4f35-938a-c435fe459738/jobs/69324

@alugowski alugowski mentioned this pull request Jun 11, 2023
Closed
tupui
tupui approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@tupui tupui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and CI is now green so merging. Thanks @alugowski!

@tupui tupui merged commit 8845c0d into scipy:main Jun 11, 2023
24 checks passed
@tupui tupui added this to the 1.12.0 milestone Jun 11, 2023
@tupui tupui added Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure maintenance Items related to regular maintenance tasks labels Jun 11, 2023
@rgommers rgommers added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 11, 2023
@tylerjereddy tylerjereddy modified the milestones: 1.12.0, 1.11.0 Jun 13, 2023
tylerjereddy pushed a commit to tylerjereddy/scipy that referenced this pull request Jun 13, 2023
@alugowski @tylerjereddy
MAINT: fix 'no such option' error in build_scipy CI (scipy#18657)
5291233
@tylerjereddy tylerjereddy mentioned this pull request Jun 13, 2023
Merged
3 tasks
@tylerjereddy tylerjereddy removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 22, 2023
@alugowski alugowski deleted the nocythoncompile branch June 24, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupui tupui tupui approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

Assignees
No one assigned
Labels
CI Items related to the CI tools such as CircleCI, GitHub Actions or Azure Documentation Issues related to the SciPy documentation. Also check https://github.com/scipy/scipy.org maintenance Items related to regular maintenance tasks
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

BUG: ci/circleci: build_scipy broken
4 participants
@alugowski @tupui @rgommers @tylerjereddy