-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: backports for 1.11.0rc2 #18671
MAINT: backports for 1.11.0rc2 #18671
Conversation
[skip actions] [skip circle]
The ppc64le one is a small test bump. The PyPy-on-Windows one is a real bug in PyPy, but it's not planned to be fixed any time soon, so the test is xfail-ed here. Closes scipygh-18632 [skip circle] [skip cirrus]
…cipy#18659) Co-authored-by: Pamphile Roy <roy.pamphile@gmail.com>
* update the SciPy 1.11.0 release notes following a set of RC2 backports
Would be good to have #18630. @rgommers marked it as a backport-candidate already (but also milestoned it for 1.12? 🤔 In any case, if it's not backported, I'll have to carry it on the feedstock, at least for ppc; this would also be manageable). Otherwise there are no additional PRs that I'm aware of that we need for the conda-forge side, thanks for checking! |
Agreed. Merged now, would be good to add to the backports here. That PR is going into 1.12; this backport PR pulls it into 1.11 - the milestones on the respective PRs indicate that; the issue itself is also marked for 1.11.0. |
The pre-release job is failing with |
The I pushed a commit that should fix both of the failing jobs. |
Speaking of numpy, does the condition |
Yes it does - the |
ae47882
to
e8614d1
Compare
Hmm, EDIT: that test has a random number seeding issue, which may explain why it behaves differently on different branches. I'll try to fix that on EDIT 2: it passed on a second run, without making a relevant change. So it's a flake or related to seeding - let's ignore it on the 1.11.x branch. |
These tests crash in a quite flaky way, as seen in scipygh-18671 and previously also in scipygh-17630. So to make sure it's not due to test ordering, avoid use of the global RandomState instance.
These tests crash in a quite flaky way, as seen in scipygh-18671 and previously also in scipygh-17630. So to make sure it's not due to test ordering, avoid use of the global RandomState instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tyler! LGTM from my perspective.
About the release notes, can we do some tweaking here? I had some talk with Matt and we might want to highlight other things in stats and in general.
Yes, please do make release notes suggestions here, or you can even open a PR against my branch or whatever suits. Apart from Matt, I think the feedback on the release notes was pretty light initially, probably the usual reason of folks being busy. |
…18630) [skip ci] --------- Co-authored-by: Ralf Gommers <ralf.gommers@gmail.com>
* Fixes scipy#18595 * use `git apply` to directly apply the patch from scipygh-18595 that worked during the RC1 phase of current release cycle; I'll skip the CI--it isn't tested there which is why the patch is needed in the first place [skip ci]
|
I will raise this to the sparse team on discord. |
@jjerphan is going to help for the sparse part tomorrow 😃 Thanks!! |
Or later tonight. 🦉 |
…linux (#18677) * CI: remove setuptools install from musllinux job No longer used/needed, since we removed the need for it from Pythran. * TST: improve seeding of problematic linalg tests + add `IS_MUSL` These tests crash in a quite flaky way, as seen in gh-18671 and previously also in gh-17630. So to make sure it's not due to test ordering, avoid use of the global RandomState instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider tylerjereddy#73.
I just opened tylerjereddy#74. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and CI is green modulo 3 unrelated failures, so good to go I'd say. I'd recommend either squash-merging this though or (preferably) squashing the ~10 separate commits that tweak the release notes entry for sparse array stuff.
* update the SciPy 1.11.0rc2 release notes following additional backports DOC: suggestions for `scipy.sparse` release notes Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Reword some sentences Remove mentions of n-dimensional sparse arrays Apply suggestions from code review DOC: update release notes for scipy.stats DOC: PR 18671 revisions * remove `diags_array` from release notes per scipygh-18599 DOC: PR 18671 revisions * update release notes after more activity
* release notes updates after another backport to 1.11.0rc2 PR
64b5cfe
to
08dc19a
Compare
That looks about right I think, a bit unfortunate that a backport got interwoven or I could have condensed even more, but that's a reduction by 10. |
LGTM now, thanks @tylerjereddy. In it goes. The hang on CirrusCI is unrelated; there's one doc warning which seems to be due to a new version of Matplotlib. That's not blocking for the release, let's deal with that in |
Still TODO:
sparse
release notes likely need a bit of tweaking, or at least for the reversion that happened cc @perimosocordiae @stefanvconda
release manager @h-vetinari if there are any concerns I'm not addressing?Backports Included here:
scipy._sensitivity_analysis
: correct statement about sums of Sobol' indices; and improve clarity and grammar #18659void
functions asnoexcept
in _rotation.pyx #18629