TST: flaky test_complex_iir_dlti
#18738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deals with the second part of scipygh-18732 * I was able to reproduce locally, but this one was even flakier--analysis of patch success below, and possibly related to subtle low-level MacOS ARM issues upstream in numpy/numpy#23996 (NumPy `1.25.0`) * before this patch, 4 trials of this command with `pytest-repeat`: `CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_signaltools.py::TestDecimate::test_complex_iir_dlti -- --count=20000` `81 failed, 19919 passed in 43.68s` `81 failed, 19919 passed in 43.79s` `20000 passed in 33.24s` `43 failed, 19957 passed in 35.17s` * after this patch, 6 trials of the same command: `20000 passed in 30.44s` `20000 passed in 33.08s` `20000 passed in 33.46s` `20000 passed in 33.45s` `20000 passed in 33.56s` `20000 passed in 33.30s` [skip circle]
tylerjereddy
added
scipy.signal
backport-candidate
|
Allowing for atol/rtol for floating-point comparisons looks a straightforward improvement, as requiring exact equality is nearly always too optimistic. So the green button it is. Thanks Tyler. |
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deals with the second part of TST, MAINT: some tests blocking 1.11.0 on MacOS ARM64 with NumPy
1.25.0#18732I was able to reproduce locally, but this one was even flakier--analysis of patch success below, and possibly related to subtle low-level MacOS ARM issues upstream in BUG: SciPy is seeing incorrect warnings on MacOS M1 (M2?)
array * scalarnumpy/numpy#23996 (NumPy1.25.0)before this patch, 4 trials of this command with
pytest-repeat:CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_signaltools.py::TestDecimate::test_complex_iir_dlti -- --count=2000081 failed, 19919 passed in 43.68s81 failed, 19919 passed in 43.79s20000 passed in 33.24s43 failed, 19957 passed in 35.17safter this patch, 6 trials of the same command:
20000 passed in 30.44s20000 passed in 33.08s20000 passed in 33.46s20000 passed in 33.45s20000 passed in 33.56s20000 passed in 33.30s[skip circle]