MAINT: more 1.11.0 backports #18743
Merged
MAINT: more 1.11.0 backports #18743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deals with the 1 of the 2 Apple silicon test failures in scipygh-18732 * I was able to reproduce locally, but because it was flaky I needed `pytest-repeat` for consistent failure: `CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_filter_design.py::TestSOSFreqz::test_fs_param -- --count=200` * I verified that with the provided patch/`atol` bump, we consistently pass even with `2000` repeats [skip circle]
* deals with the second part of scipygh-18732 * I was able to reproduce locally, but this one was even flakier--analysis of patch success below, and possibly related to subtle low-level MacOS ARM issues upstream in numpy/numpy#23996 (NumPy `1.25.0`) * before this patch, 4 trials of this command with `pytest-repeat`: `CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_signaltools.py::TestDecimate::test_complex_iir_dlti -- --count=20000` `81 failed, 19919 passed in 43.68s` `81 failed, 19919 passed in 43.79s` `20000 passed in 33.24s` `43 failed, 19957 passed in 35.17s` * after this patch, 6 trials of the same command: `20000 passed in 30.44s` `20000 passed in 33.08s` `20000 passed in 33.46s` `20000 passed in 33.45s` `20000 passed in 33.56s` `20000 passed in 33.30s` [skip circle]
* update the SciPy `1.11.0` release notes after a few more backports dealing with MacOS ARM64 test issues
|
The only failing test is |
tylerjereddy
merged commit 58c5d60
into
scipy:maintenance/1.11.x
22 of 23 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a slight disruption in the
1.11.0release process per gh-18732, so this backports two PRs to deal with that:test_complex_iir_dlti#18738Release notes were updated accordingly.
Flushing the whole CI here is probably not necessary, but I'll allow it to happen since it is still cheaper in wallclock time than having the release process restarted and halted by a surprise later. Hopefully CI is happy enough though (a few known flakes we can ignore I think), and then I'll try to restart the release process today.