Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: more 1.11.0 backports #18743

Merged
merged 3 commits into from Jun 25, 2023
Merged

MAINT: more 1.11.0 backports #18743

merged 3 commits into from Jun 25, 2023

Commits on Jun 25, 2023

  1. TST: flaky TestSOSFreqz::test_fs_param 

    * deals with the 1 of the 2 Apple silicon
test failures in scipygh-18732

* I was able to reproduce locally, but because
it was flaky I needed `pytest-repeat` for
consistent failure:
`CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_filter_design.py::TestSOSFreqz::test_fs_param -- --count=200`

* I verified that with the provided patch/`atol` bump,
we consistently pass even with `2000` repeats

[skip circle]
    @tylerjereddy
    tylerjereddy committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    db11851 View commit details
    Browse the repository at this point in the history

  2. TST: flaky test_complex_iir_dlti 

    * deals with the second part of scipygh-18732

* I was able to reproduce locally, but this one was even
flakier--analysis of patch success below, and possibly
related to subtle low-level MacOS ARM issues upstream
in numpy/numpy#23996 (NumPy
`1.25.0`)

* before this patch, 4 trials of this command
with `pytest-repeat`:
`CC=clang CXX=clang++ FC=gfortran-12 python dev.py test -t scipy/signal/tests/test_signaltools.py::TestDecimate::test_complex_iir_dlti -- --count=20000`
`81 failed, 19919 passed in 43.68s`
`81 failed, 19919 passed in 43.79s`
`20000 passed in 33.24s`
`43 failed, 19957 passed in 35.17s`

* after this patch, 6 trials of the same command:
`20000 passed in 30.44s`
`20000 passed in 33.08s`
`20000 passed in 33.46s`
`20000 passed in 33.45s`
`20000 passed in 33.56s`
`20000 passed in 33.30s`

[skip circle]
    @tylerjereddy
    tylerjereddy committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    78973aa View commit details
    Browse the repository at this point in the history

  3. DOC: update 1.11.0 relnotes 

    * update the SciPy `1.11.0` release notes
after a few more backports dealing with
MacOS ARM64 test issues
    @tylerjereddy
    tylerjereddy committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    084357e View commit details
    Browse the repository at this point in the history