ENH: stats: Implement _sf and _isf for hypsecant. #18783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The one test failure is unrelated to this PR. |
|
I can take a look at this, but would you review/merge #18714? |
mdhaber
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Given the symmetry/evenness of sech, these look correct compared to the CDF/ISF. Looks like we lose a bit when the argument of isf is very close to one due to the finite precision of np.pi and the sensitivity of tan near pi/2 (float(mp.tan(mp.pi*q/2.0)) is quite different from float(mp.tan(mp.pi*q/2.0)) with q close to 1), but seems like the right trade to make if we're not going to branch.
@WarrenWeckesser I would still appreciate a response to #18783 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.