BLD: rename setup.py to _setup.py to signal it should no longer be used
#19027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgommers
added
maintenance
…e used See the added code comment in this commit for rationale of keeping `_setup.py` around. We got another two bug reports that used `python setup.py install` in the last day (scipygh-19022 and scipygh-19026), so it's time to make that impossible. For those who really really need it, they can still manually rename `_setup.py` to `setup.py` for a while longer, but this should make it much clearer that we no longer support this install method (beyond the one conda-forge on Windows case). [skip circle] [skip cirrus]
rgommers
force-pushed
the
rename-setuppy
branch
from
10d0b85
to
e8d73fa
Compare
|
Cc @h-vetinari for visibility. Once this lands, it will require a one-line tweak in conda-forge, to move |
tylerjereddy
approved these changes
Aug 8, 2023
5 tasks
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the added code comment in this commit for rationale of keeping
_setup.pyaround. We got another two bug reports that usedpython setup.py installin the last day (gh-19022 and gh-19026), so it's time to make that impossible.For those who really really need it, they can still manually rename
_setup.pytosetup.pyfor a while longer, but this should make it much clearer that we no longer support this install method (beyond the one conda-forge on Windows case).