Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: bump tolerance to address local test_axis_nan_policy failures #20748

Merged
merged 2 commits into from
May 19, 2024
Merged

TST: bump tolerance to address local test_axis_nan_policy failures #20748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3a0eb7
TST: bump tolerance to address `test_axis_nan_policy` failures
rgommers May 19, 2024
76c725a
TST: skip highly parametrized nan-policy tests unless running with xslow
rgommers May 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions scipy/stats/tests/test_axis_nan_policy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,22 +255,23 @@ def test_axis_nan_policy_fast(hypotest, args, kwds, n_samples, n_outputs,
unpacker, nan_policy, axis, data_generator)


@pytest.mark.slow
@pytest.mark.filterwarnings('ignore::RuntimeWarning')
@pytest.mark.filterwarnings('ignore::UserWarning')
@pytest.mark.parametrize(("hypotest", "args", "kwds", "n_samples", "n_outputs",
"paired", "unpacker"), axis_nan_policy_cases)
@pytest.mark.parametrize(("nan_policy"), ("propagate", "omit", "raise"))
@pytest.mark.parametrize(("axis"), range(-3, 3))
@pytest.mark.parametrize(("data_generator"),
("all_nans", "all_finite", "mixed"))
def test_axis_nan_policy_full(hypotest, args, kwds, n_samples, n_outputs,
paired, unpacker, nan_policy, axis,
data_generator):
if hypotest in {stats.cramervonmises_2samp} and not SCIPY_XSLOW:
pytest.skip("Too slow.")
_axis_nan_policy_test(hypotest, args, kwds, n_samples, n_outputs, paired,
unpacker, nan_policy, axis, data_generator)
if SCIPY_XSLOW:
# Takes O(1 min) to run, and even skipping with the `xslow` decorator takes
# about 3 sec because this is >3,000 tests. So ensure pytest doesn't see
# them at all unless `SCIPY_XSLOW` is defined.
@pytest.mark.filterwarnings('ignore::RuntimeWarning')
@pytest.mark.filterwarnings('ignore::UserWarning')
@pytest.mark.parametrize(("hypotest", "args", "kwds", "n_samples", "n_outputs",
"paired", "unpacker"), axis_nan_policy_cases)
@pytest.mark.parametrize(("nan_policy"), ("propagate", "omit", "raise"))
@pytest.mark.parametrize(("axis"), range(-3, 3))
@pytest.mark.parametrize(("data_generator"),
("all_nans", "all_finite", "mixed"))
def test_axis_nan_policy_full(hypotest, args, kwds, n_samples, n_outputs,
paired, unpacker, nan_policy, axis,
data_generator):
_axis_nan_policy_test(hypotest, args, kwds, n_samples, n_outputs, paired,
unpacker, nan_policy, axis, data_generator)


def _axis_nan_policy_test(hypotest, args, kwds, n_samples, n_outputs, paired,
Expand Down Expand Up @@ -385,11 +386,11 @@ def unpacker(res):
"approximation.")
res = unpacker(hypotest(*data, axis=axis, nan_policy=nan_policy,
*args, **kwds))
assert_allclose(res[0], statistics, rtol=1e-15)
assert_allclose(res[0], statistics, rtol=1e-14)
assert_equal(res[0].dtype, statistics.dtype)

if len(res) == 2:
assert_allclose(res[1], pvalues, rtol=1e-15)
assert_allclose(res[1], pvalues, rtol=1e-14)
assert_equal(res[1].dtype, pvalues.dtype)


Expand Down
Loading