-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up stats._support, close statistics review issues #2778
Conversation
_chk_asarray was move to from stats to _support during the python 2 to 3 conversion to avoid some circular imports IIRC, needs checking I guess |
Some of the functions would theoretically be interesting, some of them are obsolete because pandas is doing it better. unique is essentially a We made a try several years ago to clean up the |
I don't think we want a
|
Closes scipygh-708 Closes scipygh-710 Closes scipygh-711 Closes scipygh-712
…pport Closes scipygh-599 (stats.itemfreq statistics review) Closes scipygh-706 (stats.abut statistics review - removed) Closes scipygh-707 (stats.unique statistics review - removed)
OK updated, |
The rewrite of
It really should just return the two arrays separately, but that's an API change. So how about also giving it a deprecation warning that states that the return value will change to the tuple of 1D array (items, freqs) in version 0.XX? (Or create a new function now, and warn that |
I don't think changing the number of return values is desirable; a deprecation and adding a new function ( |
Question ( I haven't looked at the details) +1 on deprecation and a good replacement, if that can count rows. |
another thing I just remembered: |
This looks good and works for me, so I'll merge it. The deprecation of |
Clean up stats._support, close statistics review issues
Thanks. |
Summary: all junk in that file. Two functions are used in glm/itemfreq, the former is deprecated and the latter rewritten in this PR. See gh-599 on discussion about keeping itemfreq.
Issues closed:
gh-599
gh-706
gh-707
gh-708
gh-710
gh-711
gh-712