Docstrings: improvement rv_discrete #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you tweak the example a little to use standard namespaces? So Other than that this looks good. |
|
Updated :) |
rgommers
added a commit
that referenced
this pull request
Sep 22, 2012
Improvements to the stats.rv_discrete docstring.
|
Thanks, merged. |
mckib2
added a commit
to mckib2/scipy
that referenced
this pull request
Apr 12, 2020
189d6572b Merge pull request #22 from ERGO-Code/master 471f6e0e8 Remove std::make_unique to make c++11 compliant 0dc437abd Merge pull request scipy#312 from matbesancon/fixc99 7aae34645 Merge pull request scipy#309 from rgommers/fix-warning 9d8e58009 Merge pull request scipy#314 from ERGO-Code/presolveCleanBounds 30341c9dc Remove example scripts folder 47b3dda38 Remove defunct test cc0cc7011 Fix optimizations typo for windows afe87ff14 Add compiler optimizations for gcc/msvc 0eac2850f Ignore cython generated files for HiGHS integration 7a9a8cc47 Merge commit 'a15ff5a21d283f4dde76e0d4b89f1eeb67ead77a' into embed-highs c9c4c8d0d Merge commit 'dc7fece0a7822e2e60c5714bd400c73512b8b2ff' into embed-highs b43bca6fe fix class to struct 94670da58 Revert "fix struct to class" c6c2873aa fix struct to class 246622607 fix c99 error 98ae809b0 Fix a build warning in lp_solver.cc with GCC 9 456a6f0f3 Merge branch 'linprog_highs' of https://github.com/mdhaber/scipy into mdhaber-linprog_highs d42f1a19f PEP8: optimize: linprog HiGHS PEP8 fixes git-subtree-dir: scipy/optimize/_highs git-subtree-split: 189d6572b984e75e811b2ea92edc3fc343229ea1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
From my point of view, the docstring of class rv_discrete() was poorly understandable.
The problem was:
Most of examples were not directly executable and mostly illustrated the ' Alternatively' section in notes.
In the new version,
I have not fully understood yet examples using <shape(s)>. But I think we must avoid examples that could not be executed "out of the box". For the moment, still there...
François.