-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: sparse/dsolve: fix dense matrix fortran order bugs in superlu wrappers #3367
Conversation
…appers This also allows passing in dense matrices to SuperLU, without needing to loop on the Python side.
Changes Unknown when pulling 2344e41 on pv:splu-bugfix into * on scipy:master*. |
static char solve_doc[] = ( | ||
"x = self.solve(b, trans)\n" | ||
"\n" | ||
"solves linear system of equations with one or sereral right hand sides.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well fix the typo here (sereral).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fix it in gh-3375 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Doesn't build with Bento (edit: also not with distutils):
|
Since this builds on Travis, likely related to numpy version (I use 1.5.1). |
The failure is due to Numpy 1.5. Fixed. (We should make one of the travis builds use this Numpy version, so these issues would be easier to catch.) |
Works for me now, so in it goes. Thanks @pv |
BUG: sparse/dsolve: fix dense matrix fortran order bugs in superlu wrappers
The splu() SuperLU wrapper has been broken since time immemorial (< 0.7.2)
for matrix inputs, because of confusion in the C code between Fortran and C
order inputs.
This is fairly simple to fix, so let's fix it. This also allows passing in dense matrices
directly to SuperLU, without needing to loop on the Python side.
Fixes gh-3363