-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two wrappers to the gaussian_kde class. #3398
Conversation
The wrappers are: - pdf - logpdf
These are new public methods, so should get docstrings. Adding unit tests is also necessary. Those live in ``scipy/stats/tests/test_kdeoth.py. You can look at existing tests and add one for each new method. |
@nicodelpiano are you planning to finish this? |
Yes, I was too busy with my master, sorry for that. |
Probably for pdf the best thing to do is copy the first line of the And for logpdf something similar. |
I am thinking that the unit test for pdf will be the same as the "test_kde_bandwidth_method" but changing the "evaluate" calls for "pdf". |
For the unit tests, I think the intention of the test would be more obvious if you just compare pdf and evaluate on an example. for the docstring: does it work to just assign the evaluate docstring, |
What do you think of this?
|
Yes I think it's good, it's directly to the point of checking an alias.
|
How about this?
|
looks good to me I think you can also add the |
The wrappers are: - pdf - logpdf
The wrappers are: - pdf - logpdf
The wrappers are: - pdf - logpdf
Changes Unknown when pulling 161f1a6 on nicodelpiano:master into * on scipy:master*. |
Is there something wrong in the patch? please let me know! |
looks good to me (I would still prefer full docstrings) |
@nicodelpiano indeed nothing wrong with this patch. Can be merged, with maybe a tweak to the docstrings. |
Merged with some changes in c0864c9. Thanks @nicodelpiano |
The wrappers are: