address svds returning nans for zero input matrix #3719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 2357848 on argriffing:singular-svds-lm into * on scipy:master*. |
|
This should be ready for review/merge. |
| # Gramian matrices have real non-negative eigenvalues. | ||
| eigvals = np.maximum(eigvals.real, 0) | ||
|
|
||
| # Copy the sophisticated detection of small eigenvalues from pinvh. |
There was a problem hiding this comment.
Maybe just write it out rather than copypaste?
The if statements and several of the assignments are redundant here...
|
The maths look OK to me. Minor comments otherwise above. |
|
@pv Thanks for your comments, I've simplified the code accordingly. |
|
Changes Unknown when pulling ba71000 on argriffing:singular-svds-lm into * on scipy:master*. |
pv
added a commit
that referenced
this pull request
Aug 23, 2014
BUG: sparse.linalg: address svds returning nans for zero input matrix
|
Thanks, merged. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3452 and passes sparse.linalg tests locally