BUG: Removed unnecessary storage of args as instance variables in Rbf #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jetuk no test is needed here. If we indeed consider |
|
Any users of |
|
If no responses within a week or so, I think I'll merge this PR. |
rgommers
added a commit
that referenced
this pull request
Aug 17, 2014
BUG: Removed unnecessary storage of args as instance variables in Rbf
|
Merged, thanks @jetuk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to
Rbf.__call__which means that the incoming arrays are no longer stored on self. This is an optimization for memory usage so that args in 'xa' are not stored between calls to Rbf.As far as I can see the usage of self.xa after a call is not documented, and this change passes existing tests. I have no idea how to write a test for this memory consumption.