BUG: fix undefined behavior in alngam #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
my fortran-fu is weak, is there a better way to do that? (INT_MAX equivalent checking overflow flags maybe?) |
INT(A) is undefined if A cannot be represented as INT
In MIPS the result is positive triggering a huge loop for:
scipy.stats.skellam.sf(np.inf, 10, 11)
juliantaylor
force-pushed
the
skellam-ub
branch
from
290b089
to
26f8a09
Compare
|
Seems fine to me (and there's probably no way to do this better in F77). |
|
The test is already there (somewhere in stats). It was causing build timeouts on a mips machine which is how I found it. |
pv
added a commit
that referenced
this pull request
Aug 24, 2014
BUG: special: fix undefined behavior in alngam INT(A) is undefined if A cannot be represented as INT In MIPS the result is positive triggering a huge loop.
|
Ok, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT(A) is undefined if A cannot be represented as INT
In MIPS the result is positive triggering a huge loop for: