Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal.__init__.py: remove duplicated get_window entry #3955

Merged
merged 1 commit into from
Sep 2, 2014

Conversation

megies
Copy link
Contributor

@megies megies commented Sep 2, 2014

For a moment I was a bit confused about a duplicated mention of get_window routine(s) (with different description) in the overview of scipy.signal (i.e. in scipy.signal.__init__.py docstring). So for a moment I was concerned about a possible name clash, especially because I stumbled over this trying to restore backwards compatibility in our code (regarding the "new" signal.windows submodule).

I think it should be avoided to mention the routine (it seems there never was a different routine with the same name) twice in two different sections.

I'm basing this on master being a bit unsure whether it should rather be based on the current maintanance branch..

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3c5e59c on megies:signal_docstring_get_window into 6f9b0a7 on scipy:master.

pv added a commit that referenced this pull request Sep 2, 2014
DOC: signal: remove duplicated `get_window` entry
@pv pv merged commit c8eeac1 into scipy:master Sep 2, 2014
@pv
Copy link
Member

pv commented Sep 2, 2014

Thanks, seems fine

@pv pv added this to the 0.15.0 milestone Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants