BUG: sparse.linalg: make *Inv objects in arpack garbage-collectable by refcount #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y refcount Setting self._method = self._method by passing self._method to LinearOperator causes a reference cycle in the various inverse operators. self._method = Class._method works. The reference cycle prevents these objects from being GC'd immediately by refcount. Since these objects hold large amounts of data, it's easy to run out of memory before cyclic GC runs, if eigs/eigsh is called in a tight loop, so it's best to not create refcycles here.
|
Fixes gh-3362 |
|
I don't completely understand the scipy linear operator interface, but this looks OK to me so I'll merge. |
argriffing
added a commit
that referenced
this pull request
Sep 9, 2014
BUG: sparse.linalg: make *Inv objects in arpack garbage-collectable by refcount
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting self._method = self._method by passing self._method to
LinearOperator causes a reference cycle in the various inverse
operators. self._method = Class._method works.
The reference cycle prevents these objects from being GC'd immediately
by refcount. Since these objects hold large amounts of data, it's easy
to run out of memory before cyclic GC runs, if eigs/eigsh is called in a
tight loop, so it's best to not create refcycles here.
[Issue spotted from a post on stackoverflow --- causes eigs/eigsh to appear to leak memory in a tight for loop raising MemoryErrors. The issue can be worked around by calling gc.collect(), but it's best to not create unnecessary refcycles in the first place.]