-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: rewrite of stats.ppcc_plot #4563
Conversation
This PR should be pretty straightforward, any takers for a review? |
I haven't reviewed the |
Reading through the code: The changes look good to me, I don't see any problems and it improves the code. I haven't paid any attention to what the empty array behavior is now in various functions. |
Plots are all sensible as well, except a plot for length-1 which of course is just a single point in a figure. For empty input |
@WarrenWeckesser that sounds good. Although easier, why not merge this PR now (since Josef just reviewed it) and then you make your proposed change on top of it? |
@rgommers: That's fine, too--less work for you, which is good. :) |
ENH: rewrite of stats.ppcc_plot
Great, thanks. Merging. |
tukeylambda ppf change is here: #4692 |
Closes Statistics Review issue gh-679.
Also some minor fixes to
stats.probplot
andstats.tukeylambda
are included.