MAINT: sparse: warn on todia() with many diagonals #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: minor optimization using `return_inverse=True`
rgommers
added
scipy.sparse
maintenance
rgommers
added a commit
that referenced
this pull request
Oct 11, 2015
MAINT: sparse: warn on todia() with many diagonals
|
LGTM, merged. Thanks @perimosocordiae |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 100 number is arbitrary, but it's what the no-op condition was checking for previously.
This PR should also yield minor speedups by using the
return_inverseflag ofnp.unique, instead of constructing the inverse indices manually.