BUG: Error message contained wrong values #5815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ master #5815 diff @@
======================================
Files 235 235
Stmts 43347 43348 +1
Branches 8165 8165
Methods 0 0
======================================
+ Hit 33722 33723 +1
Partial 2594 2594
Missed 7031 7031
|
|
2.6 is still supported according to |
| policies = ['propagate', 'raise', 'omit'] | ||
| if nan_policy not in policies: | ||
| raise ValueError("nan_policy must be one of {%s}" % | ||
| ', '.join("'%s'" % s for s in policies)) |
There was a problem hiding this comment.
Is this what you're worried about? This should work fine on Py2.6.
That's a mistake, the install docs should have been updated in gh-5756. I'll send a PR. |
|
Merging. The test is greatly appreciated, as this is obviously something that went wrong in the past. Thanks @TomAugspurger! |
larsmans
added a commit
that referenced
this pull request
Feb 7, 2016
BUG: stats: Error message contained wrong values
rgommers
added
scipy.stats
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5814
I included a test, but I'm not sure how useful it is. Can easily remove it if need be.
EDIT: You've dropped support for 2.6 right? I think my generator expression would fail on that.