ENH: allow long indices of sparse matrix with umfpack in spsolve() #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 21, 2016
@@ master #6085 diff @@
======================================
Files 238 238
Stmts 43863 43865 +2
Branches 8218 8218
Methods 0 0
======================================
+ Hit 34293 34294 +1
Partial 2603 2603
- Missed 6967 6968 +1
|
|
Seems reasonable, merged. |
|
Thanks! |
rgommers
added
scipy.sparse.linalg
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating scikit-umfpack [1] for matrices with long (int64) indices (work in progress), so this PR is going to be needed to be able to use that feature from scipy.
[1] https://github.com/scikit-umfpack/scikit-umfpack/