-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: Add circle-CI #6192
MRG: Add circle-CI #6192
Conversation
That looks good, thanks Eric! 1500 build minutes a month may be borderline, but we'll see how far we get with a free account I guess. |
I've been using it on another repo for a couple of months with fewer PRs/commits but probably longer build times and so far we've been okay, so I'm optimistic. I'll go ahead and merge and activate in a couple of days unless there are other comments. |
For reference, here is the TravisCI artifacts support: https://docs.travis-ci.com/user/uploading-artifacts/. Summary: it doesn't store artifacts, only supports uploading to Amazon S3. Hence CircleCI is better in this regard. We currently only build the docs after a PR is merged (to update the dev docs on docs.scipy.org). |
in it goes, thanks @Eric89GXL |
@rgommers can you enable CircleCI on their website? I don't think I have sufficient permissions |
done, building at https://circleci.com/gh/scipy/scipy/1 now |
Eh, make that failed at https://circleci.com/gh/scipy/scipy/1
|
Oh yeah, can you also set it to use 14.04 instead of 12.04? It's in the
settings for the project on CirceCI
|
Looks like I had permission to change it, so I did. Next build will hopefully work. |
I rebased and push forced #5989 so hopefully we see it work there |
Worked like a charm this time. |
Doesn't seem to be working now:
https://circleci.com/gh/scipy/scipy/5
https://circleci.com/gh/scipy/scipy/8
|
Or maybe it just needs rebases.
|
Yeah it looks like it doesn't build the merge version which is surprising.
|
Add CircleCI doc building, with an artifact of the new docs. This should hopefully make it easier for e.g. @rgommers to critique my mediocre docstring plots.
Closes #6129.
Produces this:
https://circle-artifacts.com/gh/Eric89GXL/scipy/27/artifacts/0/home/ubuntu/scipy/doc/build/html-scipyorg/generated/scipy.signal.remez.html#scipy.signal.remez