-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples to scipy.ndimage.filters #6253
Conversation
|
||
Examples | ||
-------- | ||
>>> import scipy.misc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import style: from scipy import ndimage, misc
And a minor thing for next commits: please use the prefixes given in http://docs.scipy.org/doc/numpy-dev/dev/gitwash/development_workflow.html#writing-the-commit-message |
Overall +1, nice to have some examples for |
Thank you for pointing me to the commit prefixes; I adjusted my commit message (and changed the other things you mentioned). |
Code looks good now, but the example is a pretty bad green: https://circle-artifacts.com/gh/scipy/scipy/145/artifacts/0/home/ubuntu/scipy/doc/build/html-scipyorg/generated/scipy.ndimage.prewitt.html#scipy.ndimage.prewitt How about adding |
That looks much better. One last issue - the second figure for If you insert a
|
Much better. In it goes. Thanks @MartinThoma! |
No description provided.