Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: signal: use assert_allclose for testing near-equality in FP #6327

Merged
merged 1 commit into from
Jun 29, 2016
Merged

TST: signal: use assert_allclose for testing near-equality in FP #6327

merged 1 commit into from
Jun 29, 2016

Conversation

ev-br
Copy link
Member

@ev-br ev-br commented Jun 28, 2016

This should address two test failures out of three reported in #6286 (comment)

@ev-br ev-br added maintenance Items related to regular maintenance tasks scipy.signal labels Jun 28, 2016
@ev-br ev-br added this to the 0.18.0 milestone Jun 28, 2016
@ev-br ev-br added the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jun 28, 2016
@larsoner
Copy link
Member

LGTM. I didn't realize filtfilt cast to float like that, even when the system and the coefficients were int. But I guess it's okay to do it.

@ev-br
Copy link
Member Author

ev-br commented Jun 29, 2016

I'll merge it then. Thanks for having a look Eric

@ev-br ev-br merged commit 1c8385d into scipy:master Jun 29, 2016
@ev-br ev-br deleted the assert_equal_fp branch June 29, 2016 21:02
@ev-br ev-br removed the backport-candidate This fix should be ported by a maintainer to previous SciPy versions. label Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.signal
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ev-br @larsoner