MAINT: special: rename *_roots functions
#6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
People might not be so into this, but I thought I'd give it a try. :-) |
person142
added
scipy.special
maintenance
|
+1 I like these changes. Names are now much more descriptive, which always helps. Saves people from having to go look at the docstring for even a basic understanding of what a function is about. |
|
Previous discussion: #6591 (comment) |
|
One week with some +1's and no objections, so I'm removing the "needs-decision" label. |
person142
removed
the
needs-decision
A function like `j_roots` is renamed to `roots_jacobi` so that it has a more descriptive name and matches the functions `jacobi` and `eval_jacobi`. The old names are kept as aliases, so all changes are backwards compatible.
person142
force-pushed
the
orthogonal-roots
branch
from
030ded8
to
18c1929
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function like
j_rootsis renamed toroots_jacobiso that ithas a more descriptive name and matches the functions
jacobiandeval_jacobi. The old names are kept as aliases, so all changes arebackwards compatible.