DOC: improvement in scipy.interpolate.splprep #7073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
reviewed
Feb 18, 2017
scipy/interpolate/fitpack.py
Outdated
| @@ -110,6 +110,7 @@ def splprep(x, w=None, u=None, ub=None, ue=None, k=3, task=0, s=None, t=None, | |||
| ----- | |||
| See `splev` for evaluation of the spline and its derivatives. | |||
| The number of dimensions N must be smaller than 11. | |||
| Splprep pads zeros at the end which is a cross-link to BSpline as BSpline does not require zero-padding. | |||
There was a problem hiding this comment.
I don't think this sentence clarifies much.
There was a problem hiding this comment.
Then what should be added , I mean what should I focus upon ?
pv
added
needs-work
ev-br
reviewed
Feb 25, 2017
| @@ -110,6 +110,8 @@ def splprep(x, w=None, u=None, ub=None, ue=None, k=3, task=0, s=None, t=None, | |||
| ----- | |||
| See `splev` for evaluation of the spline and its derivatives. | |||
| The number of dimensions N must be smaller than 11. | |||
| The c array retruned consists of k+1 zeros at the end | |||
| while BSpline does not require zero-padding. | |||
There was a problem hiding this comment.
Could be useful to contrast it to splrep (does it zero-pad?)
There was a problem hiding this comment.
Ok, so should I include the that splrep does not zero-pad also in the docstring?
|
Thank you @ashwinpathak20 , your commits are squashed and merged in gh-7678. Your authorship is preserved :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look at my changes applied in accordance with the issue #6618 in scipy.interpolate.splprep.