MAINT: stats: Deprecate frechet_l and frechet_r. #7838
Conversation
WarrenWeckesser
added
maintenance
WarrenWeckesser
force-pushed
the
deprecate-frechets
branch
2 times, most recently
from
2dd9e24
to
1edb964
Compare
|
Does anyone know what's going on with the OSX test runs on Travis-CI? |
|
From https://www.traviscistatus.com/: |
|
OK, thanks Ralf. |
scipy/stats/_continuous_distns.py
Outdated
| usage is deprecated because of possible confusion with the (quite different) | ||
| Frechet distribution. To preserve the existing behavior of the program, use | ||
| `scipy.stats.weibull_min`. For the Frechet distribution (i.e. the Type II | ||
| extreme value distribution), use `scipy.stats.frechet`.""" |
There was a problem hiding this comment.
Now that you've split the PR, this needs a tweak. stats.frechet doesn't exist.
There was a problem hiding this comment.
Same comment applies to the deprecation message for frechet_l
There was a problem hiding this comment.
Oops, missed that one. I just pushed a fix.
|
LGTM except for the minor change needed to the deprecation message. |
* Update the header text to indicate that these are Weibull distributions, not Frechet distributions. * Fixed some mistakes in the moment formulas. * Reformatted the LaTeX. * Provided explicit median formula.
WarrenWeckesser
force-pushed
the
deprecate-frechets
branch
from
1edb964
to
14af048
Compare
|
LGTM now, in it goes. Thanks @WarrenWeckesser |
|
@WarrenWeckesser are you going to continue immediately on the other parts that were in gh-7190? If not, then it may be a good idea to open a new issue to keep track of that code. |
|
Can #3258 be closed now? |
good catch, done |
Fix for #3258. This PR is an alternative to #3275. The text of the
frechetdistribution docstring was taken from that PR, with only a little editing. Many thanks to @ligon for getting the work started.The old names
frechet_landfrechet_r, which were actually what are conventionally called the Weibull distribution, are deprecated. To deprecate these, the deprecation decorator is applied to each public method. The old implementations offrechet_landfrechet_rare still available asweibull_maxandweibull_min, respectively.