TST: Use diff. values for decimal keyword for single and doubles #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
changed the title
oleksandr-pavlyk
force-pushed
the
feature/test_ndimage
branch
from
a9d74ca
to
aee01db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test_ndimage.pythe same default value fordecimalkeyword inassert_allclosewas used in tests.This commit proposes to use different values for different floating point types, allowing to strengthen the check for doubles, and weaken the checks for floats where appropriate.
Lowering of the value of the keyword was necessary with Intel (R) Distribution for Python* for floats, when Intel (R) MKL was being used to implement FFT functionality via package mkl_fft.
@rgommers