Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: sparse: Use deduped data for numpy ufuncs #8232

Merged
merged 2 commits into from
Apr 7, 2018
Merged

BUG: sparse: Use deduped data for numpy ufuncs #8232

merged 2 commits into from
Apr 7, 2018

Conversation

perimosocordiae
Copy link
Member

Fixes gh-8228. Technically only required for ufuncs where f(a) + f(b) != f(a+b), but this is a simple-enough fix for the general case.

tylerjereddy
tylerjereddy reviewed Dec 20, 2017
View reviewed changes
Copy link
Contributor

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be sensible to add a unit test that confirms that the behavior reported in the issue no longer exists to prevent i.e., a regression?

@rgommers rgommers added the maintenance Items related to regular maintenance tasks label Jan 19, 2018
@perimosocordiae
Copy link
Member Author

I "added" unit tests by disabling the XFAIL annotation on the existing test.

@perimosocordiae perimosocordiae added this to the 1.1.0 milestone Apr 5, 2018
@perimosocordiae
Copy link
Member Author

Added the 1.1.0 milestone, as this is ready to go.

@pv pv merged commit 1d1a18b into scipy:master Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy left review comments

Assignees
No one assigned
Labels
maintenance Items related to regular maintenance tasks scipy.sparse
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

bug for log1p on csr_matrix
4 participants
@perimosocordiae @tylerjereddy @pv @rgommers