Fixed bug reported in issue #8181 #8296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem consisted of a single tabulation which shouldn't have been there, and caused the function _open_file never to return, when ".mat" was to be appended. I removed the tabulation, and nothing else.
|
Can you also add the relevant test. |
|
Travis fails on python2 because py2 throws IOError instead of FileNotFoundError (and doesn't know what the latter is). I don't know much about this. Ideas? |
|
You can make the test check for IOError instead of FileNotFoundError
(which is a subclass of IOError).
|
|
This looks ok now. |
|
Looks like comments are addressed and tests are added. Merging. |
chrisb83
added a commit
to chrisb83/scipy
that referenced
this pull request
Jan 27, 2018
…invgauss * 'master' of git://github.com/scipy/scipy: (71 commits) ENH: added Moyal distribution to scipy.stats (scipy#8223) Misc. typos BENCH: bump pinned Cython version BUG: Fix right_multiplied_operator for least_squares address review comments Change copyright to outdated 2008-2016 to 2008-year FIX: io.loadmat raises TypeError instead of IOError (scipy#8296) DOC: Fix typos about missing np. namespace DOC: Removed spurious brackets and fixed typo Bugfix in integrate/romb DOC: Moved the eigvals examples to the end of the docstring DOC: Added "Examples" to all missing functions make sure _onenorm_matrix_power_nnm actually returns a float DOC: make public API documentation cross-link to refguide. MAINT: Housekeeping to minimize the compiler warnings Examples for linalg/decmop eigvals function DOC: integrate: fix reference numbers in docstrings CI: use numpy 1.13 for refguide check build DOC: fix non-ascii characters in docstrings which broke the doc build. MAINT: stats weightedtau use np.sum check for nan ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem consisted of a single tabulation which shouldn't have been there, and caused the function _open_file never to return, when ".mat" was to be appended. I removed the tabulation, and nothing else.
Fixes #8181