Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: don't use pyproject.toml in the CI builds #8724

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Conversation

pv
Copy link
Member

@pv pv commented Apr 14, 2018

Pass on --no-build-isolation to pip, so that it does not break the numpy
version fixing etc. careful environment setup in the CI.

In principle we might want to check the build isolation stuff works in the CI,
but that's for another day.

Make the python 3.5 wheel build use build isolation, the rest of the builds don't.

Trying to use build isolation gives the error (https://travis-ci.org/scipy/scipy/jobs/366522826)

pip wheel
Processing /home/travis/build/scipy/scipy
  Could not find a version that satisfies the requirement numpy==1.8.2 (from versions: 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.11.0, 1.11.1rc1, 1.11.1, 1.11.2rc1, 1.11.2, 1.11.3, 1.12.0b1, 1.12.0rc1, 1.12.0rc2, 1.12.0, 1.12.1rc1, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2)
No matching distribution found for numpy==1.8.2

Fixing that probably is for another day...

@pv pv added this to the 1.1.0 milestone Apr 14, 2018
@pv
Copy link
Member Author

pv commented Apr 14, 2018

I'm going to remove pyproject.toml from scipy 1.1.0, this stuff is untested and I think not fit for release at the moment.

Too late for that, it was already in scipy 1.0.0 so we'll just have to live with it.
The issue with the Windows failures is that on Windows, the numpy version to use for releases is different as it's based on the availability of wheels.

Apparently pip also considers only wheels for deciding "what versions are available", which also breaks the travis builds as we want to build against numpy 1.8.2 that has no wheels for py3.5.

@pv pv force-pushed the pip10-ci-fix branch 2 times, most recently from dd936cc to 7d56847 Compare April 14, 2018 15:45
Pass on --no-build-isolation to pip, so that it does not break the numpy
version fixing etc. careful environment setup.
@pv pv merged commit e665e3c into scipy:master Apr 14, 2018
@pv
Copy link
Member Author

pv commented Apr 14, 2018

Merging to fix the CI

pv added a commit that referenced this pull request Apr 14, 2018
Pass on --no-build-isolation to pip, so that it does not break the numpy
version fixing etc. careful environment setup.

(cherry picked from commit e665e3c)
rgommers added a commit to rgommers/scipy that referenced this pull request Apr 3, 2019
Broken now, see discussion on scipygh-9924

This is a change to scipygh-8724 which added --no-build-isolation.
That PR does discuss that testing build isolation in CI would be a good idea;
it just didn't address that at the time.
rgommers added a commit to rgommers/scipy that referenced this pull request Apr 12, 2019
Broken now, see discussion on scipygh-9924

This is a change to scipygh-8724 which added --no-build-isolation.
That PR does discuss that testing build isolation in CI would be a good idea;
it just didn't address that at the time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant