BUG: Fix division by zero in trust-region optimization methods #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check convergence condition before starting iteration. Solves problem with division by zero if we have a Jacobian with zero magnitude. Add corresponding tests. Fixes scipy#8686.
ilayn
added
defect
|
thanks, lgtm |
pv
added
the
backport-candidate
pv
added a commit
that referenced
this pull request
May 4, 2018
BUG: optimize: fix division by zero in trust-region optimization methods Check convergence condition before starting iteration. Solves problem with division by zero if we have a Jacobian with zero magnitude. Add corresponding tests. (cherry picked from commit fc09f2f)
tylerjereddy
removed
the
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check convergence condition before starting iteration. Solves problem
with division by zero if we have a Jacobian with zero magnitude.
Add corresponding tests.
Fixes #8686.
Work done together @panvaf @lizweer @mezdahun