Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove deprecated functions for 1.3.0 #9325

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

ilayn
Copy link
Member

@ilayn ilayn commented Sep 30, 2018

scipy.misc has quite a number of functions either deprecated or relocated. I have removed them and the related data, tests and cleaned up docstrings. Also removed the scipy.ndimage.imread function as it was an alias with PIL dependency and being the only function in ndimage.io.py, file is also removed.

Let me know if there are other deprecations in the pipeline that I forgot.

@ilayn ilayn added scipy.ndimage scipy.misc maintenance Items related to regular maintenance tasks labels Sep 30, 2018
@ilayn ilayn added this to the 1.2.0 milestone Sep 30, 2018
@ev-br
Copy link
Member

ev-br commented Oct 2, 2018

(There's also a bunch of deprecated stuff in interpolate.)

I actually wonder if we should merge this just after branching 1.2.0, so that it lands in 1.3.0 instead. Maybe a year from 1.0.0 is a little too fast for some of these. Also run this through the mailing list to probe waters?

@ilayn
Copy link
Member Author

ilayn commented Oct 3, 2018

I actually wonder if we should merge this just after branching 1.2.0, so that it lands in 1.3.0 instead. Maybe a year from 1.0.0 is a little too fast for some of these.

1.2.0 is actually what we promised in the current documentation. But I don't mind waiting a bit more.

Also run this through the mailing list to probe waters?

True, I'll do that.

@rgommers
Copy link
Member

Yes I agree, waiting one more release is probably better as this is going to affect quite a few users. The 1.2.0 in the deprecation message was my doing I think; 1.3.0 would have been better. Bumping the milestone.

@rgommers rgommers modified the milestones: 1.2.0, 1.3.0 Oct 29, 2018
@rgommers rgommers changed the title DEP: Remove deprecated functions for 1.2.0 DEP: Remove deprecated functions for 1.3.0 Oct 29, 2018
@rgommers
Copy link
Member

this needs a rebase now

@ilayn
Copy link
Member Author

ilayn commented Nov 19, 2018

No problem I'll do that.

@ilayn
Copy link
Member Author

ilayn commented Nov 19, 2018

Great now another doctest failure seemingly out of the blue sky 😃

@rgommers
Copy link
Member

All green now. In it goes. Thanks @ilayn.

I'll send a message to the list too - this one will hurt a little ....

@rgommers
Copy link
Member

In it goes.

In a minute - just double checking the imread/imsave stuff.

@rgommers
Copy link
Member

Okay, we decided to remove imread et al rather than making new wrappers in gh-7869. Users who run into this removal, see that issue.

@rgommers rgommers merged commit 1e3b290 into scipy:master Nov 20, 2018
@rgommers
Copy link
Member

@ilayn could you also add these removals to the backwards-incompatible changes section of the 1.3.0 release notes?

@ev-br
Copy link
Member

ev-br commented Nov 20, 2018

A follow-up with more esoteric stuff in interpolate in gh-9511

DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Sep 27, 2021
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see
scipy/scipy#9325.

Move _pilutil.py from scipy/externals, which is the location for
vendored files, to scipy/utils, which is a location for locally
maintained files.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Sep 27, 2021
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see
scipy/scipy#9325.

Move _pilutil.py from scipy/externals, which is the location for
vendored files, to scipy/utils, which is a location for locally
maintained files.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Sep 27, 2021
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0,
see scipy/scipy#9325.

Move _pilutil.py from sklearn/externals, which is the location
for vendored files, to sklearn/utils, which is a location for
locally maintained files, including orphan vendored files like
this one.
DimitriPapadopoulos added a commit to DimitriPapadopoulos/scikit-learn that referenced this pull request Feb 11, 2022
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0,
see scipy/scipy#9325.

Move _pilutil.py from sklearn/externals, which is the location
for vendored files, to sklearn/utils, which is a location for
locally maintained files, including orphan vendored files like
this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Items related to regular maintenance tasks scipy.misc scipy.ndimage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants