-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEP: Remove deprecated functions for 1.3.0 #9325
Conversation
fc71c38
to
5ef0248
Compare
(There's also a bunch of deprecated stuff in I actually wonder if we should merge this just after branching 1.2.0, so that it lands in 1.3.0 instead. Maybe a year from 1.0.0 is a little too fast for some of these. Also run this through the mailing list to probe waters? |
1.2.0 is actually what we promised in the current documentation. But I don't mind waiting a bit more.
True, I'll do that. |
Yes I agree, waiting one more release is probably better as this is going to affect quite a few users. The 1.2.0 in the deprecation message was my doing I think; 1.3.0 would have been better. Bumping the milestone. |
this needs a rebase now |
No problem I'll do that. |
Great now another doctest failure seemingly out of the blue sky 😃 |
All green now. In it goes. Thanks @ilayn. I'll send a message to the list too - this one will hurt a little .... |
In a minute - just double checking the |
Okay, we decided to remove |
@ilayn could you also add these removals to the backwards-incompatible changes section of the 1.3.0 release notes? |
A follow-up with more esoteric stuff in |
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see scipy/scipy#9325. Move _pilutil.py from scipy/externals, which is the location for vendored files, to scipy/utils, which is a location for locally maintained files.
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see scipy/scipy#9325. Move _pilutil.py from scipy/externals, which is the location for vendored files, to scipy/utils, which is a location for locally maintained files.
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see scipy/scipy#9325. Move _pilutil.py from sklearn/externals, which is the location for vendored files, to sklearn/utils, which is a location for locally maintained files, including orphan vendored files like this one.
File scipy/misc/pilutil.py has been removed from Scipy 1.3.0, see scipy/scipy#9325. Move _pilutil.py from sklearn/externals, which is the location for vendored files, to sklearn/utils, which is a location for locally maintained files, including orphan vendored files like this one.
scipy.misc
has quite a number of functions either deprecated or relocated. I have removed them and the related data, tests and cleaned up docstrings. Also removed thescipy.ndimage.imread
function as it was an alias with PIL dependency and being the only function inndimage.io.py
, file is also removed.Let me know if there are other deprecations in the pipeline that I forgot.