Fix defaut value for 'mode' in 'ndimage.shift' in the doc #9387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
added
the
Documentation
tylerjereddy
approved these changes
Oct 18, 2018
There was a problem hiding this comment.
Thanks! This looks good and matches the suggested fix from @ilayn. I think Ilhan has also been working hard on the CI issues, which here appear to be unrelated to the simple doc change.
Also, worth noting that we normally prefix commits and PR titles related to documentation with DOC:. For other changes, there's a list here.
Probably good to go, but I'll let Ilhan confirm / merge.
|
Thanks a lot @lbellomo for reporting it and for the PR. It is indeed good to go. Keep them coming 😃 |
|
I did not know about prefixes, I'll be more attentive for the next time. |
|
Oops we basically forgot to check the other use cases. Ralf mentioned it in #9262 but we overlooked it here. I'll close that one as a duplicate. |
This was referenced Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR references this issue I submitted earlier.
Fixes #9383