MAINT: interpolate: use operator.index for checking/coercing to integers #9444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-br
added
scipy.interpolate
maintenance
|
Should we wait the 1.2 branch for this or go ahead and put this in? Since it is a private function I also don't expect any problems |
tylerjereddy
approved these changes
Nov 6, 2018
There was a problem hiding this comment.
Merging based on comments from two core devs above, a quick review of the changes, the best practices note on stack overflow on this matter, and CI is all green.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the recommended idiom for checking integer inputs.
Strictly speaking, this is a backcompat break since some ValueErrors become TypeErrors, but I believe this is harmless (can't see any reason to catch these errors in library or user code).